-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: document labels bug #27198
Conversation
Currently only CPU profile utilizes tag information. This change documents that fact
Message from Gerrit User 5065: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
This PR (HEAD: a701779) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/131275 to see it. Tip: You can toggle comments from me using the |
Message from komu wairagu: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from komu wairagu: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from Emmanuel Odeke: Patch Set 2: Thank you for this change Komu! I am kindly also paging Hyang-Ah and Austin in addition to Brad's review. Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from Hyang-Ah Hana Kim: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
removed "BUG(hyangah): ". Documenting it as a limitation seems sufficient.
This PR (HEAD: be99a12) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/131275 to see it. Tip: You can toggle comments from me using the |
Message from komu wairagu: Patch Set 3: (1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from Hyang-Ah Hana Kim: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from komu wairagu: Patch Set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from komu wairagu: Patch Set 5: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from komu wairagu: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from komu wairagu: Patch Set 7: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from Hyang-Ah Hana Kim: Patch Set 8: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Message from Hyang-Ah Hana Kim: Patch Set 8: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/131275. |
Currently only CPU profile utilizes tag information. This change documents that fact Updates #23458 Change-Id: Ic893e85f63af0da9100d8cba7d3328c294e8c810 GitHub-Last-Rev: be99a12 GitHub-Pull-Request: #27198 Reviewed-on: https://go-review.googlesource.com/c/go/+/131275 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
This PR is being closed because golang.org/cl/131275 has been merged. |
Currently only CPU profile utilizes tag information.
This change documents that fact
Updates #23458