Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: respect -mod=readonly when performing 'mod verify' #31729

Closed
wants to merge 1 commit into from
Closed

cmd/go: respect -mod=readonly when performing 'mod verify' #31729

wants to merge 1 commit into from

Conversation

haosdent
Copy link
Contributor

@haosdent haosdent commented Apr 28, 2019 •
edited
Loading

Fixes #31372

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 28, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 6e33b78) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/174258 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1

Thank for this change Haosdent! I shall page some experts for this.

Also, we'll need to add a test in cmd/go/testdata/script/mod_readonly.txt

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=151a9624

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from haosdent huang:

Patch Set 1:

Patch Set 1: Run-TryBot+1

Thank for this change Haosdent! I shall page some experts for this.

Also, we'll need to add a test in cmd/go/testdata/script/mod_readonly.txt

WoW, thx @emmanuel. Let me add later and ping you again. Orz

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/151a9624/freebsd-amd64-12_0_76ccf8be.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

6 of 20 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/151a9624/freebsd-amd64-12_0_76ccf8be.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/151a9624/openbsd-amd64-64_5811a489.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/151a9624/linux-amd64_c285063d.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/151a9624/linux-386_f37896b3.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/151a9624/windows-amd64-2016_d74ab243.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/151a9624/windows-386-2008_7b3680a6.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1: Code-Review-1

https://golang.org/cl/166237 seems to implement the same change more comprehensively.

This change needs a test; otherwise, it's not obvious to me that it actually fixes the repro case reported in #31372.

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 3 times, most recently from a1b0af9 to 93a79bb Compare October 1, 2019 22:09
@gopherbot gopherbot force-pushed the master branch 3 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:56
@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=151a9624

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/151a9624/freebsd-amd64-12_0_76ccf8be.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result-1

6 of 20 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/151a9624/freebsd-amd64-12_0_76ccf8be.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/151a9624/openbsd-amd64-64_5811a489.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/151a9624/linux-amd64_c285063d.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/151a9624/linux-386_f37896b3.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/151a9624/windows-amd64-2016_d74ab243.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/151a9624/windows-386-2008_7b3680a6.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/174258.
After addressing review feedback, remember to publish your drafts!

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/go: 'mod verify' should not modify the go.mod file
4 participants
@haosdent @gopherbot @googlebot @heschi