net/url: fail TestParseErrors test when getting an unwanted error #33876
Conversation
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does. Updates golang#33646 and golang#29098
googlebot
added
the
cla: yes
|
This PR (HEAD: de1e898) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/191966 to see it. Tip: You can toggle comments from me using the |
|
Message from Štefan Baebler: Patch Set 1: This fixes the tests for #33646, which was introduced by #29098 Originally committed as #32954 Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
Message from Filippo Valsorda: Patch Set 1: Run-TryBot+1 Code-Review+2 (1 comment) Thank you! Minor note on the commit message. Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=b6a0fa38 Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
Message from Gobot Gobot: Patch Set 1: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
Surprise, surprise. |
|
Message from Štefan Baebler: Patch Set 1: (1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
@stefanb Your change is identical to https://go-review.googlesource.com/c/go/+/185080/ - why did you create an exact replica of what has been reverted just before (because it fails)? Instead of uploading something that works. Is it funnier this way? |
|
@av86743 Because this needs to get in as soon as the #33646 is fixed. In the same |
|
Message from Filippo Valsorda: Patch Set 1: (2 comments) Please fix the failing case, which is now expected to return an error, per #33646. Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
So, basically, you don't care that |
|
This PR (HEAD: 53beeb5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/191966 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: bd26c57) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/191966 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: e6844c5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/191966 to see it. Tip: You can toggle comments from me using the |
|
Message from Filippo Valsorda: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
Message from Gobot Gobot: Patch Set 5: TryBots beginning. Status page: https://farmer.golang.org/try?commit=a73c20fb Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
Message from Štefan Baebler: Patch Set 5:
Tnx for the pointer! Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
@av86743 That is a testing construct to fail a test if the tested |
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does Fixes #33646 Updates #29098 Change-Id: I069521093e2bff8b1fcd41ffd3f9799f3108bc61 GitHub-Last-Rev: e6844c5 GitHub-Pull-Request: #33876 Reviewed-on: https://go-review.googlesource.com/c/go/+/191966 Run-TryBot: Filippo Valsorda <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]>
|
Message from Gobot Gobot: Patch Set 5: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/191966. |
|
This PR is being closed because golang.org/cl/191966 has been merged. |
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does Fixes golang#33646 Updates golang#29098 Change-Id: I069521093e2bff8b1fcd41ffd3f9799f3108bc61 GitHub-Last-Rev: e6844c5 GitHub-Pull-Request: golang#33876 Reviewed-on: https://go-review.googlesource.com/c/go/+/191966 Run-TryBot: Filippo Valsorda <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]>
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does Fixes golang#33646 Updates golang#29098 Change-Id: I069521093e2bff8b1fcd41ffd3f9799f3108bc61 GitHub-Last-Rev: e6844c5 GitHub-Pull-Request: golang#33876 Reviewed-on: https://go-review.googlesource.com/c/go/+/191966 Run-TryBot: Filippo Valsorda <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]>
The TestParseErrors test function was not strict with unwanted errors
received from url.Parse(). It was not failing in such cases, now it does
Fixes #33646
Updates #29098