-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mime: extend "builtinTypes" to include a more complete list of common types #69533
base: master
Are you sure you want to change the base?
Conversation
Simply implements the first recommended type for each file extension listed in MDN https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types However, this excludes ".3gp" and ".3gp2" as from from I can tell it is not possible to know if it is video or audio solely from file extension. As far as I can tell there are two previous PRs that each implemented a type simply because they were in common use. Updates golang#69530
This PR (HEAD: 4526569) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/614376. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/614376. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/614376. |
Message from Aidan Welch: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/614376. |
Message from Ian Lance Taylor: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/614376. |
Message from Ian Lance Taylor: Patch Set 2: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/614376. |
Comment with the source of the builtin types Updates golang#69530
This PR (HEAD: 3cc1e3c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/614376. Important tips:
|
Message from Aidan Welch: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/614376. |
Simply implements the first recommended type for each file extension listed
in MDN
https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
However, this excludes ".3gp" and ".3gp2" as from from I can tell it is not
possible to know if it is video or audio solely from file extension.
As far as I can tell there are at least two previous PRs that each
implemented a type simply because they were in common use, this would try
to implement a more expansive list rather than piecemeal implementations.
Updates #69530