New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/socks: permit authenticating with an empty password #157

Closed

iseki0 wants to merge 1 commit into golang:master from iseki0:master

Contributor

iseki0 commented Dec 13, 2022 •

edited

Loading

The behavior is accepted widely, and I found no reason to deny it.

Fixes golang/go#57285


          socks: SOCKS5 proxy with empty password should be allowed

b00ecb1

The behavior is accepted widely, and I found no reason to deny it.

Fixes #57285

Contributor Author

iseki0 commented Dec 13, 2022

why gopherbot haven't come?

Contributor

gopherbot commented Dec 13, 2022

This PR (HEAD: b00ecb1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/457355 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Dec 13, 2022

Message from Damien Neil:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 13, 2022

Message from Damien Neil:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 13, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 13, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

iseki0 changed the title ~~socks: SOCKS5 proxy with empty password should be allowed~~ internal/socks: permit authenticating with an empty password

Contributor

gopherbot commented Dec 14, 2022

Message from iseki:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 14, 2022

Message from iseki:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 14, 2022

Message from Damien Neil:

Patch Set 2: Code-Review+2 Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 15, 2022

Message from Than McIntosh:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 25, 2022

Message from iseki:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 31, 2023

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457355.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          internal/socks: permit authenticating with an empty password

3d5a8ee

The behavior is accepted widely, and I found no reason to deny it.

Fixes golang/go#57285

Change-Id: I39b07295cc89481ea0d6b70b71f2aa57f1a01407
GitHub-Last-Rev: b00ecb1
GitHub-Pull-Request: #157
Reviewed-on: https://go-review.googlesource.com/c/net/+/457355
Run-TryBot: Damien Neil <[email protected]>
Auto-Submit: Damien Neil <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

Contributor

gopherbot commented Apr 7, 2023

This PR is being closed because golang.org/cl/457355 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet