Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: add LocalAddr and RemoteAddr to quic.Conn #225

Closed
wants to merge 1 commit into from
Closed

quic: add LocalAddr and RemoteAddr to quic.Conn #225

wants to merge 1 commit into from

Conversation

jfgiorgi
Copy link
Contributor

@jfgiorgi jfgiorgi commented Oct 30, 2024 •
edited
Loading

These are missing for quic.Conn.

Fixes golang/go#70138

@gopherbot
Copy link
Contributor

This PR (HEAD: a326378) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/623157.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@jfgiorgi
Copy link
Contributor Author

Fixes golang/go#70138

@gopherbot
Copy link
Contributor

Message from Jean-François Giorgi:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jean-François Giorgi:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@jfgiorgi jfgiorgi changed the title quic: add LocalAddr() and RemoteAddr() to quic.Conn quic: add LocalAddr and RemoteAddr to quic.Conn Nov 1, 2024
@gopherbot
Copy link
Contributor

Message from Jean-François Giorgi:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jean-François Giorgi:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jean-François Giorgi:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-06T21:04:25Z","revision":"ecc78ce21d5aa8218ca74f7f3fe0e3fcde42c5ec"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/623157.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 6, 2024
@jfgiorgi @gopherbot
quic: add LocalAddr and RemoteAddr to quic.Conn
d7f220d 
These are missing for quic.Conn.

Fixes golang/go#70138

Change-Id: Ia443ffe0e73e143be5c29233a1ceb7cb16951acd
GitHub-Last-Rev: a326378
GitHub-Pull-Request: #225
Reviewed-on: https://go-review.googlesource.com/c/net/+/623157
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: David Chase <[email protected]>
Auto-Submit: Damien Neil <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/623157 has been merged.

@gopherbot gopherbot closed this Nov 6, 2024
@jfgiorgi jfgiorgi deleted the connaddr branch November 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: x/net/quic: add LocalAddr and RemoteAddr to quic.Conn
2 participants
@jfgiorgi @gopherbot