google/internal/externalaccount: Removed URL validation for google URLs in ADC files #627
Conversation
|
This PR (HEAD: 45e2b9c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/465696 to see it. Tip: You can toggle comments from me using the |
|
Message from Cody Oss: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/465696. |
|
This PR (HEAD: 15d7759) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/465696 to see it. Tip: You can toggle comments from me using the |
|
Message from Alex Eitzman: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/465696. |
|
Message from Cody Oss: Patch Set 2: Code-Review+2 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/465696. |
|
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/465696. |
|
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/465696. |
|
Message from Leo Siracusa: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/465696. |
…Ls in ADC files Removes URL validation for token_url, service_account_impersonation_url to allow for TPC urls and adds line to the docs to warn users. See googleapis/google-auth-library-nodejs#1517 for same change in node.js library. Change-Id: I85fa67ee0b99deed2adb75668a1b5501851c499c GitHub-Last-Rev: 15d7759 GitHub-Pull-Request: #627 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/465696 Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Leo Siracusa <[email protected]>
|
This PR is being closed because golang.org/cl/465696 has been merged. |
Removes URL validation for token_url, service_account_impersonation_url to allow for TPC urls and adds line to the docs to warn users. See googleapis/google-auth-library-nodejs#1517 for same change in node.js library.