Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorgroup: producing a better failure message for a programmer error #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shifengbin
Copy link

SetLimit(10)
Go(xx) //start a groutine ,g.done be called if task done
SetLimit(-1) //<-- g.sem=nil

but g.done is not atomic, if g.sem=nil maybe block the goroutine

@gopherbot
Copy link

This PR (HEAD: 51b7016) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sync/+/413094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from fengbin shi:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Bryan Mills:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094.
After addressing review feedback, remember to publish your drafts!

@shifengbin shifengbin changed the title errorgroup: fix setLimit cause goroutine leak errorgroup: producing a better failure message for a programmer error Jun 22, 2022
@gopherbot
Copy link

Message from fengbin shi:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants