Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language: remove compatibility with go < 1.2 #37

Closed
wants to merge 1 commit into from
Closed

language: remove compatibility with go < 1.2 #37

wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Contributor

This was added in 9f86e0b to provide compatibility with go1.1, which is an obsolete version.

@thaJeztah
language: remove compatibility with go < 1.2
a009d8c 
This was added in 9f86e0b to provide
compatibility with go1.1, which is an obsolete version.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@gopherbot
Copy link
Contributor

This PR (HEAD: a009d8c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/442796 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/442796.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/442796.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/442796.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Oct 14, 2022
@thaJeztah @gopherbot
language: remove compatibility with go < 1.2
1bdb400 
This was added in 9f86e0b to provide compatibility with go1.1, which is an obsolete version.

Change-Id: Ie3edbf9bd377608344e14ba327c437cbc4aa0c9a
GitHub-Last-Rev: a009d8c
GitHub-Pull-Request: #37
Reviewed-on: https://go-review.googlesource.com/c/text/+/442796
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Joedian Reid <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/442796 has been merged.

@gopherbot gopherbot closed this Oct 14, 2022
@thaJeztah thaJeztah deleted the remove_go1.1_compat branch October 14, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @gopherbot