Skip to content

Commit

Permalink
cmd/godoc: skip TestWeb if waitForServerReady fails
Browse files Browse the repository at this point in the history
This test fails frequently, with a failure mode that is difficult to
diagnose. (golang/go#50436 may help with that eventually.)

For now, skip the test to reduce noise on the build dashboard.

For golang/go#50014.

Change-Id: I182be5c705846631c983bd5b6c51ab90b71a216a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/403534
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
gopls-CI: kokoro <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
Bryan C. Mills authored and gopherbot committed May 2, 2022
1 parent 6872d3b commit 04fc2ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/godoc/godoc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func waitForServerReady(t *testing.T, cmd *exec.Cmd, addr string) {
15*time.Second,
false)
if err := <-ch; err != nil {
t.Fatal(err)
t.Skipf("skipping due to https://go.dev/issue/50014: %v", err)
}
}

Expand Down

0 comments on commit 04fc2ba

Please sign in to comment.