Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more errors in go list #131

Closed
wants to merge 1 commit into from
Closed

Ignore more errors in go list #131

wants to merge 1 commit into from

Conversation

sauyon
Copy link

@sauyon sauyon commented Jul 4, 2019

Adds some hacks to work around go list bugs causing golang/go#31462 and
golang/go#32755.

In addition, appends error messages generated in this manner to stdout instead
of discarding stdout entirely, and ensures that this does not cause a
conflicting package error by adding an internal field to packageJson.

@gopherbot
Copy link
Contributor

This PR (HEAD: be4f779) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/185077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/185077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 24b94ac) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/185077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 68654d0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/185077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: a0370a2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/185077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 0a80f6c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/185077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Adds some hacks to work around go list bugs causing golang/go#31462 and
golang/go#32755.

In addition, appends error messages generated in this manner to stdout instead
of discarding stdout entirely, and ensures that this does not cause a
conflicting package error by adding an internal field to packageJson.
@gopherbot
Copy link
Contributor

This PR (HEAD: fdded40) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/185077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@sauyon
Copy link
Author

sauyon commented Sep 9, 2019

/comments off

@sauyon
Copy link
Author

sauyon commented Oct 31, 2019

Closing as these seem to have been fixed.

@sauyon sauyon closed this Oct 31, 2019
bsponge added a commit to bsponge/tools that referenced this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants