New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "internal/lsp/cache: disable GOPACKAGESDRIVER" #297

Closed

steeve wants to merge 1 commit into golang:master from unknown repository

Contributor

steeve commented Apr 3, 2021 •

edited

Loading

Now that https://github.com/bazelbuild/rules_go has a working prototype of a GOPACKAGESDRIVER, it may be time to revert that commit.

The draft implementation is at bazel-contrib/rules_go#2858.


          Revert "internal/lsp/cache: disable GOPACKAGESDRIVER"

0df6c91

This reverts commit 092357f.

google-cla bot added the cla: yes label

steeve mentioned this pull request

go/tools: add gopackagesdriver bazel-contrib/rules_go#2858

Merged

Contributor

gopherbot commented Apr 3, 2021

This PR (HEAD: 0df6c91) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/307169 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Apr 4, 2021

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 4, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=03c66b31

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 4, 2021

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/61dcd5ea-c59e-4bd5-937e-463face653fd

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 4, 2021

Message from Rebecca Stambler:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 4, 2021

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/61dcd5ea-c59e-4bd5-937e-463face653fd

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 4, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 5, 2021

Message from Heschi Kreinick:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 6, 2021

Message from Brandon Bennett:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 6, 2021

Message from Rebecca Stambler:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 6, 2021

Message from Steeve Morin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307169.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          Revert "internal/lsp/cache: disable GOPACKAGESDRIVER"

c602466

Now that https://github.com/bazelbuild/rules_go has a working prototype of a `GOPACKAGESDRIVER`, it may be time to revert that commit.

The draft implementation is at bazel-contrib/rules_go#2858.

Change-Id: Ia738e8be448d936f8a3b2b421d0a765f94bbff52
GitHub-Last-Rev: 0df6c91
GitHub-Pull-Request: #297
Reviewed-on: https://go-review.googlesource.com/c/tools/+/307169
Reviewed-by: Rebecca Stambler <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Trust: Rebecca Stambler <[email protected]>
Run-TryBot: Rebecca Stambler <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Go Bot <[email protected]>

Contributor

gopherbot commented Apr 6, 2021

This PR is being closed because golang.org/cl/307169 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels