New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls/doc: Add plugin for Lapce to gopls documentation #413

Closed

Elara6331 wants to merge 1 commit into golang:master from Elara6331:add-lapce-plugin-gopls-docs

Contributor

Elara6331 commented Nov 6, 2022

Add Lapce Go plugin to gopls documentation


          Add plugin for Lapce to gopls documentation

37762df

google-cla bot commented Nov 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Contributor

gopherbot commented Nov 6, 2022

This PR (HEAD: 37762df) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/448235 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Nov 6, 2022

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/448235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/448235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2022

Message from Robert Findley:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/448235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 9, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 2: Patch Set 1 was rebased

Copied Votes:

Code-Review+2 (copy condition: "changekind:NO_CHANGE OR is:ANY")

Please don’t reply on this GitHub thread. Visit golang.org/cl/448235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 9, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/448235.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          gopls/doc: Add plugin for Lapce to gopls documentation

Add [Lapce](https://lapce.dev) Go plugin to `gopls` documentation

Change-Id: I58ec42d69708b519cfba3de1cdee269ffecdbbc4
GitHub-Last-Rev: 37762df
GitHub-Pull-Request: #413
Reviewed-on: https://go-review.googlesource.com/c/tools/+/448235
Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Contributor

gopherbot commented Nov 9, 2022

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 9, 2022

This PR is being closed because golang.org/cl/448235 has been merged.

gopherbot closed this

Elara6331 deleted the add-lapce-plugin-gopls-docs branch

November 11, 2022 20:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet