Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache status size calculation #3611

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fix: cache status size calculation #3611

merged 1 commit into from
Feb 18, 2023

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Feb 18, 2023

related #2971

golangci-lint cache status always shows 10B if cache directory exists.
That's the size of trim.txt.

@ldez ldez added bug Something isn't working area: cache labels Feb 18, 2023
@ldez ldez self-requested a review February 18, 2023 01:27
@ldez ldez changed the title Fix cache status size calculation fix: cache status size calculation Feb 18, 2023
ldez
ldez approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit fe53ca0 into golangci:master Feb 18, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@johejo @SeigeC
fix: cache status size calculation (golangci#3611)
744cb4e
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: cache bug Something isn't working
Projects
None yet
Milestone
v1.51
Development

Successfully merging this pull request may close these issues.
2 participants
@johejo @ldez