Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Replace deprecated deadline flag with timeout #53

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Replace deprecated deadline flag with timeout #53

merged 1 commit into from
Oct 14, 2019

Conversation

vthiery
Copy link
Contributor

@vthiery vthiery commented Oct 14, 2019

The --deadline flag has been marked as deprecated in golangci/golangci-lint#793.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2019

CLA assistant check
All committers have signed the CLA.

@tac0turtle
Copy link

Does this have to be merged for golangci bot to work or did the api merge solve it?

@jirfag jirfag merged commit 993d511 into golangci:master Oct 14, 2019
@jirfag
Copy link
Member

jirfag commented Oct 14, 2019

fixed and released, thank you!

@vthiery vthiery deleted the replace-deadline-flag-with-timeout branch October 14, 2019 22:15
@tac0turtle
Copy link

thank you for the merge, I believe this broke the section of golangci.yml

service:	
  golangci-lint-version: 1.19.x

since now the bot is hardcoded to timeout and does not contain deadline. we don't have an issue to update the version, but this may annoy others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants