Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to preventDefault inside passive event listener due to target being treated as passive #1026

Closed
simonyouth opened this issue Aug 24, 2018 · 1 comment
Closed

Unable to preventDefault inside passive event listener due to target being treated as passive #1026

simonyouth opened this issue Aug 24, 2018 · 1 comment

Comments

@simonyouth
Copy link

simonyouth commented Aug 24, 2018 •
edited
Loading

howler.js:308 [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive.

[See] https://www.chromestatus.com/features/5093566007214080.
Is it necessary to modify related code to be like this?

if (e.cancelable) { if (!e.defaultPrevented) { e.preventDefault(); } }
goldfire added a commit that referenced this issue Aug 25, 2018
@goldfire
Remove unnecessary preventDefault in unlock to fix Chrome issues
d0e52e9 
Fixes #1003 #1011 #1025 #1026
@goldfire
Copy link
Owner

Thanks, this has now been fixed and I'll get a v2.0.15 out soon.

ringcrl pushed a commit to ringcrl/howler.js that referenced this issue Apr 21, 2019
@goldfire
Remove unnecessary preventDefault in unlock to fix Chrome issues
30623fc 
Fixes goldfire#1003 goldfire#1011 goldfire#1025 goldfire#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goldfire @simonyouth