Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Howls that fail to load aren't removed from Howler.howls when calling unload() #978

Closed
dgrenzo opened this issue Jun 20, 2018 · 1 comment

Comments

@dgrenzo
Copy link

dgrenzo commented Jun 20, 2018

let failed_howl = new Howl({ src: [''], onloaderror: () => { Howler.unload(); } });

I think it is because the .splice is happening inside a loop at line 1583 of howler.core.js that never gets executed for Howls that haven't loaded.

@goldfire
Copy link
Owner

Thanks! It was indeed in the wrong spot and shouldn't have been inside that for loop.

ringcrl pushed a commit to ringcrl/howler.js that referenced this issue Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants