fix play to avoid starting from beginning after pause #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardeois
changed the title
When playing a 'paused' howl, we were instanciating a new `sound` every time. Instead we should use the existing `sound` if: - `_paused === true` - `_ended === false` This basically rollbacks this commit be4e445#diff-1e099b745600c69cbaacbe86736975fc fixes #1101
|
This causes #1060 to happen again, which is why that code was removed in the first place. |
|
Interesting, but I don't understand the #1060 bug var sound = new Howl({
src: [intro, backAudio],
...shouldn't we assume |
|
Both should now be fixed with d22ddcf, but let me know if it still isn't working for you. |
|
Perfect thank you ! I'll take a look |
|
yes I confirm it's working thanks @goldfire ! |
obiot
added a commit
to melonjs/melonJS
that referenced
this pull request
Dec 20, 2018
|
@goldfire do you plan on releasing this soon? |
|
@clementdevos Yes, we've got a big update to one of our games today and then I plan on getting a 2.1.1 release out either today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing a 'paused' howl, we were instanciating a new
soundeverytime.
Instead we should use the existing
soundif:_paused === true_ended === falseThis basically rollbacks this commit be4e445#diff-1e099b745600c69cbaacbe86736975fc
fixes #1101