Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use jsdom-global: error HowlerGlobal is not defined #1331

Merged
merged 1 commit into from
May 10, 2020
Merged

use jsdom-global: error HowlerGlobal is not defined #1331

merged 1 commit into from
May 10, 2020

Conversation

newapx
Copy link
Contributor

@newapx newapx commented May 3, 2020

No description provided.

@goldfire goldfire merged commit 7c331ec into goldfire:master May 10, 2020
@onelsonic onelsonic mentioned this pull request Jun 5, 2020
Closed
@onelsonic
Copy link

Hi @newapx ,
maybe we should activate this with a flag variable?
So we can toggle it on and off if needed?

Since this fix is now preventing to use Howler in Electron from html files.
It simply stopped working in Electron.

things were working fine prior this fix in versions v.2.1.3

@mikolajroszak mikolajroszak mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newapx @onelsonic @goldfire