fix wav support in Safari 14 #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2020
dotpao
reviewed
Oct 26, 2020
| @@ -273,7 +273,7 @@ | |||
| opus: !!audioTest.canPlayType('audio/ogg; codecs="opus"').replace(/^no$/, ''), | |||
| ogg: !!audioTest.canPlayType('audio/ogg; codecs="vorbis"').replace(/^no$/, ''), | |||
| oga: !!audioTest.canPlayType('audio/ogg; codecs="vorbis"').replace(/^no$/, ''), | |||
| wav: !!audioTest.canPlayType('audio/wav; codecs="1"').replace(/^no$/, ''), | |||
| wav: !!(audioTest.canPlayType('audio/wav; codecs="1"') || audioTest.canPlayType('audio/wav')).replace(/^no$/, ''), | |||
There was a problem hiding this comment.
I don't think it is a real scenario, but what if
audioTest.canPlayType('audio/wav; codecs="1"') returns "no"
and
audioTest.canPlayType('audio/wav;') returns "maybe" ?
you still would get wav as an empty string ""
Maybe you can change it to:
wav: !!(audioTest.canPlayType('audio/wav; codecs="1"').replace(/^no$/, '') || audioTest.canPlayType('audio/wav').replace(/^no$/, ''))
jjhamshaw
added a commit
to jjhamshaw/useAudioPlayer
that referenced
this pull request
Oct 28, 2020
E-Kuerschner
pushed a commit
to E-Kuerschner/useAudioPlayer
that referenced
this pull request
Oct 28, 2020
* feat: include .wav file example * fix: wav files not working in Safari (goldfire/howler.js#1415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howler.js 2.2.0 doesn't play WAV files in Safari 14, because this method is returning empty string (i.e. false) in Safari 14:
audioTest.canPlayType('audio/wav; codecs="1"'). I created an issue for it: #1414So I added another option without specifying
codecsattribute which fix this. Here is demo to test it: https://stackblitz.com/edit/js-bvgnv8?file=index.js