Fix a bug with AudioBufferSourceNode #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldfire#226 It seems as though AudioBufferSourceNode can get caught in cases where the seek and duration are negative "Failed to execute 'start' on 'AudioBufferSourceNode': The duration provided (-0.17) is less than the minimum bound (0)" We can protect this by defaulting to 0 when we seek or set a duration below 0.
|
Hey @goldfire this could get merged in at some point. Thanks |
|
This should technically never happen, so I'm wondering if we've got another issue elsewhere leading to this. Do we know any scenarios that can cause this? |
|
I wasn't able to trace out where the negative values originate from. I'll look further into it as well |
|
We've been seeing this with CasinoRPG as well and it just seems to be very edge-case timing issues. I haven't found a good solution other than what you've got in this PR, so I'm going to go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#226
It seems as though AudioBufferSourceNode can get caught in cases where the seek and duration are negative
"Failed to execute 'start' on 'AudioBufferSourceNode': The duration provided (-0.17) is less than the minimum bound (0)"
We can protect this by defaulting to 0 when we seek or set a duration below 0.