Fix for WebAudio context not being unlocked on Android Chrome >= 55. #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a test case for this? I've been trying to reproduce the issue on latest Chrome on Android and haven't been able to so far. |
|
Sorry - forgot to mention that this only happens on cross origin iframes. |
|
This page reproduces the issue (on Android Chrome): And this has the fix: |
|
Thanks for the test cases! |
ringcrl
pushed a commit
to ringcrl/howler.js
that referenced
this pull request
Apr 21, 2019
Fix for WebAudio context not being unlocked on Android Chrome >= 55.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered situations in which audio won't play on latest Android Chrome.
Recent Chrome changes cause AudioContext() to stay locked in suspended state, unless
resume()is explicitly called from a stack initiated by user gesture.This commit fixes it.