Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .toJSON() function on objects to be used #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rhodgkins
Copy link

@rhodgkins rhodgkins commented Oct 16, 2018

Firebase database itself allows toJSON to be used when storing data (I'm guessing through the use of JSON.stringify).

I've changed the .from method to check for objects and the presence of this method and use it.

Also updated any failing tests and added new ones to cover the change.

Note that this will mean that new Date() is now a valid value, stored as '2018-10-16T10:12:00.060Z' for example.

@rhodgkins
Copy link
Author

Also added node 8 to test matrix - I've changed the node 6 check node --version | grep v6\. to not check for node 4 instead so 6 and 8 are now included.

I'm not sure why the builds are failing though - a basic npm t on node 6 and 8 work fine! (Node 4 build was failing before this change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant