Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command 'docker-squash IMAGE_NAME' doesn't re-tag IMAGE_NAME #151

Closed
praiskup opened this issue Jun 28, 2017 · 1 comment
Closed

command 'docker-squash IMAGE_NAME' doesn't re-tag IMAGE_NAME #151

praiskup opened this issue Jun 28, 2017 · 1 comment
Milestone
1.0.7

Comments

@praiskup
Copy link

According to docker-squash --help ..

  -t TAG, --tag TAG     Specify the tag to be used for the new image. by
                        default it'll be set to 'image' argument

.. the new docker image should be tagged to IMAGE_NAME; but it doesn't happen now -- one needs to use:

docker IMAGE_NAME -t IMAGE_NAME
@praiskup praiskup mentioned this issue Jun 28, 2017
Closed
praiskup pushed a commit to sclorg/container-common-scripts that referenced this issue Jun 28, 2017
@praiskup
Fix squashing - docker-squash does not tag image by default (it procl…
5439bef 
…aims it)

Also use the newest docker-squash-1.0.5

docker-squash report: goldmann/docker-squash#151

Fixes #13
@goldmann
Copy link
Owner

Ooops, that help page is wrong, sorry about that! If -t is not set, it'll not add any tags.

@goldmann goldmann added this to the 1.0.6 milestone Jul 17, 2017
@goldmann goldmann modified the milestones: 1.0.6, 1.0.7 Sep 6, 2017
@goldmann goldmann modified the milestones: 1.0.7, 1.0.x Feb 13, 2018
goldmann added a commit that referenced this issue Feb 13, 2018
@goldmann
Fix misleading information in help about tagging
26e1306 
If tag is not specified, no tag will be added.

Fixes #151
@goldmann goldmann mentioned this issue Feb 13, 2018
Merged
goldmann added a commit that referenced this issue Feb 13, 2018
@goldmann
Fix misleading information in help about tagging
d0bac43 
If tag is not specified, no tag will be added.

Fixes #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.7
Development

No branches or pull requests
2 participants
@goldmann @praiskup