Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minio Cataloger - fix List call - token should be on 3. position #1212

Merged
merged 2 commits into from
May 9, 2019
Merged

Minio Cataloger - fix List call - token should be on 3. position #1212

merged 2 commits into from
May 9, 2019

Conversation

marpio
Copy link
Member

@marpio marpio commented May 8, 2019

What is the problem I am trying to address?
Minios's Cataloger impl. contains a call to ListObjectsV2 but it provided the token on position 2 instead of 3 and so the token was never used.

@marpio marpio requested a review from a team as a code owner May 8, 2019 20:19
@marpio marpio changed the title Fix List call - token should be on 3. position Minio Cataloger - fix List call - token should be on 3. position May 8, 2019
arschles
arschles approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marpio :shipit:

I'm gonna add a follow-up issue to write a test for this. I think it's been broken for a while.

@arschles arschles mentioned this pull request May 9, 2019
Open
@arschles arschles merged commit b2bcdce into gomods:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arschles arschles arschles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marpio @arschles