Fix SensioLabs Insight major errors.

gomoob · Aug 25, 2016 · 125d55b · 125d55b
1 parent 685661f
commit 125d55b
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 8 deletions.
diff --git a/src/main/php/Gomoob/BinaryDriver/JavaDriver.php b/src/main/php/Gomoob/BinaryDriver/JavaDriver.php
@@ -50,7 +50,7 @@ public static function create(LoggerInterface $logger = null, $configuration = [
 
         try {
             return static::load($binaries, $logger, $configuration);
-        } catch (BinaryDriverExecutableNotFound $e) {
+        } catch (ExecutableNotFoundException $e) {
             throw new ExecutableNotFoundException('Unable to load java', $e->getCode(), $e);
         }
     }

diff --git a/src/main/php/Gomoob/Java/Io/UnsupportedEncodingException.php b/src/main/php/Gomoob/Java/Io/UnsupportedEncodingException.php
@@ -0,0 +1,16 @@
+<?php
+
+/**
+ * Copyright 2016 SARL GOMOOB. All rights reserved.
+ */
+namespace Gomoob\Java\Io;
+
+/**
+ * The Character Encoding is not supported.
+ *
+ * @author Baptiste GAILLARD ([email protected])
+ */
+class UnsupportedEncodingException extends IOException
+{
+    // Empty
+}
diff --git a/src/main/php/Gomoob/MetadataExtractor/Imaging/Png/PngChunkType.php b/src/main/php/Gomoob/MetadataExtractor/Imaging/Png/PngChunkType.php
@@ -2,12 +2,14 @@
 
 /**
  * gomoob/php-metadata-extractor
-*
-* @copyright Copyright (c) 2016, GOMOOB SARL (http://gomoob.com)
-* @license   http://www.opensource.org/licenses/mit-license.php MIT (see the LICENSE.md file)
-*/
+ *
+ * @copyright Copyright (c) 2016, GOMOOB SARL (http://gomoob.com)
+ * @license   http://www.opensource.org/licenses/mit-license.php MIT (see the LICENSE.md file)
+ */
 namespace Gomoob\MetadataExtractor\Imaging\Png;
 
+use Gomoob\Java\Io\UnsupportedEncodingException;
+
 use Gomoob\Java\Lang\IllegalArgumentException;
 
 /**
@@ -208,7 +210,7 @@ public function hashCode()
     }
 }
 
-/* FIXME: Will be fixed when static initializers will be added in PHP
+/* TODO: Will be fixed when static initializers will be added in PHP
  * 
  * ----------------------------------------------------------------------
  * FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

diff --git a/src/main/php/Gomoob/MetadataExtractor/Metadata/Tag.php b/src/main/php/Gomoob/MetadataExtractor/Metadata/Tag.php
@@ -38,8 +38,6 @@ class Tag
      */
     public function __constrct($tagType, Directory $directory)
     {
-        var_dump($tagType);
-
         $this->tagType = $tagType;
         $this->directory = $directory;
     }