Don't try to sync-navigate to a node that is hidden in layout.

PiperOrigin-RevId: 683225642
google-ai-edge · Oct 7, 2024 · 4e98ee0 · 4e98ee0
1 parent 557efd5
commit 4e98ee0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/ui/src/components/visualizer/sync_navigation_button.ts b/src/ui/src/components/visualizer/sync_navigation_button.ts
@@ -113,14 +113,13 @@ export class SyncNavigationButton {
           SyncNavigationMode.MATCH_NODE_ID,
           SyncNavigationMode.VISUALIZER_CONFIG,
           SyncNavigationMode.UPLOAD_MAPPING_FROM_COMPUTER,
-          SyncNavigationMode.LOAD_MAPPING_FROM_CNS,
         ]
       : [
           SyncNavigationMode.DISABLED,
           SyncNavigationMode.MATCH_NODE_ID,
           SyncNavigationMode.UPLOAD_MAPPING_FROM_COMPUTER,
-          SyncNavigationMode.LOAD_MAPPING_FROM_CNS,
         ];
+
     // If there is sync navigation data passed through visualizer config, set
     // the sync navigation data for the "visualizer config" mode and select the
     // mode by default.

diff --git a/src/ui/src/components/visualizer/webgl_renderer.ts b/src/ui/src/components/visualizer/webgl_renderer.ts
@@ -696,7 +696,12 @@ export class WebglRenderer implements OnInit, OnDestroy {
             data.nodeId,
           );
           const mappedNode = this.curModelGraph.nodesById[mappedNodeId];
-          if (mappedNode && mappedNode.id !== this.selectedNodeId) {
+          const hideInLayout = isOpNode(mappedNode) && mappedNode.hideInLayout;
+          if (
+            mappedNode &&
+            mappedNode.id !== this.selectedNodeId &&
+            !hideInLayout
+          ) {
             this.revealNode(mappedNodeId, false);
           }
         }