-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] API Calls like visualize_from_config can't process extensions. #84
Comments
Hi @vproHacks, we reviewed your PR and request -- There are probably additional changes needed, we would like to understand your use case better (why you want to make this change) in order for us to help guide you better. |
Hey! I simply wanted to configure the model_explorer using the inbuilt model_explorer.visualize_from_config(
config=model_explorer_config,
no_open_in_browser=True,
port=model_explorer_port,
extensions=['my_adapter']
) |
Hi @vproHacks, we are working on unit tests to be able to provide a harness to test out your changes. Thanks for your patience. |
@yijie-yang @pkgoogle Any updates? It's been a while, just hoping that this doesn't get lost. |
Yes, thanks! We'll add more unit tests to the python package for the code health later. For this PR, it's simple and we can directly approve it. |
API Calls can be seen in
src/server/package/src/model_explorer/apis.py
, I'd assume a simple modification like adding the extensions keyword argument as seen incmdline.py
of the same parent directory would suffice.The text was updated successfully, but these errors were encountered: