Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning notebook updated to include csv upload #300

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

nidhinpd-YML
Copy link
Contributor

  • Code to provide csv as training dataset included.
  • Separate and detailed section for Dataset preparation.
  • Added more details about different types of dataset we can provide.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Oct 4, 2024
quickstarts/Tuning.ipynb Show resolved Hide resolved
quickstarts/Tuning.ipynb Show resolved Hide resolved
@pcoet
Copy link
Member

pcoet commented Oct 5, 2024

@MarkDaoust Could you take a look at this? I had a couple of questions about documenting protos.

quickstarts/Tuning.ipynb Show resolved Hide resolved
quickstarts/Tuning.ipynb Show resolved Hide resolved
quickstarts/Tuning.ipynb Show resolved Hide resolved
quickstarts/Tuning.ipynb Show resolved Hide resolved
@markmcd
Copy link
Member

markmcd commented Oct 8, 2024

Could you take a look at this? I had a couple of questions about documenting protos.

I've done a drive-by. Agree on the protos comment - thanks for fixing that @nidhinpd-YML.

quickstarts/Tuning.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks Nidhin

@markmcd markmcd merged commit 05ad283 into google-gemini:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants