Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AIS template #303

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Simplify AIS template #303

merged 10 commits into from
Nov 5, 2024

Conversation

MarkDaoust
Copy link
Contributor

@MarkDaoust MarkDaoust commented Oct 7, 2024

This is about the simplest I can make it. The many ways that AIS may send a file are the source of some of the complexity. A "no-files" version could simplify things a lot.

We loose three things if we do that:

  1. There's no "chat" (but we could split chat to it's own template).
  2. It's harder for users to tell what went wrong if something breaks.
  3. I removed the "show the conversation" code.
    • It's nice that it lets the user see what they're sending.
    • But it is long/complex.

WDYT?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 7, 2024
@MarkDaoust
Copy link
Contributor Author

I think this is ready to submit.

@MarkDaoust MarkDaoust merged commit cfaea8d into main Nov 5, 2024
3 of 4 checks passed
@markmcd markmcd deleted the AIS_template branch November 5, 2024 06:45
@google-gemini google-gemini deleted a comment Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants