Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some flutter files as generated #154

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

natebosch
Copy link
Collaborator

Add a .gitattributes file with some patterns for files created by the
flutter templates.

This list is the patterns that look the least likely to be manually
edited, although there are many other files with generated (and
unedited) boilerplate that look like it might change in a manual
commit at some point which will still add noise in new app PRs.

  • .metada, flutter/CMakeLists.txtx,
    GenerateDPluginRegistrant.swift, and the generated_* pattern files
    have comments indicating they are generated and should not be edited.
  • The Runner.xcodeproj and Runner.xcworkspace directories contain
    xml files and look very unlikely to be hand-edited.

Add a `.gitattributes` file with some patterns for files created by the
flutter templates.

This list is the patterns that look the least likely to be manually
edited, although there are many other files with generated (and
unedited) boilerplate that look like it _might_ change in a manual
commit at some point which will still add noise in new app PRs.
- `.metada`, `flutter/CMakeLists.txtx`,
  `GenerateDPluginRegistrant.swift`, and the `generated_*` pattern files
  have comments indicating they are generated and should not be edited.
- The `Runner.xcodeproj` and `Runner.xcworkspace` directories contain
  xml files and look very unlikely to be hand-edited.
@natebosch natebosch requested a review from devoncarew May 9, 2024 00:46
@natebosch natebosch mentioned this pull request May 9, 2024
Copy link
Collaborator

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - I think this will help make things like the the sample PRs easier to review

@natebosch natebosch merged commit aba663e into main May 9, 2024
1 check passed
@natebosch natebosch deleted the flutter-generated-files branch May 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants