Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No public description #4893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

No public description #4893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorflow_federated/cc/core/impl/aggregation/core/tensor_aggregator_registry_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ namespace {

class MockFactory : public TensorAggregatorFactory {
MOCK_METHOD(StatusOr<std::unique_ptr<TensorAggregator>>, Create,
(const Intrinsic&), (const override));
(const Intrinsic&), (const, override));
MOCK_METHOD(StatusOr<std::unique_ptr<TensorAggregator>>, Deserialize,
(const Intrinsic&, std::string), (const override));
(const Intrinsic&, std::string), (const, override));
};

REGISTER_AGGREGATOR_FACTORY("foobar", MockFactory);
Expand Down
4 changes: 2 additions & 2 deletions tensorflow_federated/cc/core/impl/aggregation/core/tensor_data_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ class MockTensorData : public TensorData {
public:
MockTensorData(size_t data_pointer_offset, size_t size);

MOCK_METHOD(const void*, data, (), (const override));
MOCK_METHOD(size_t, byte_size, (), (const override));
MOCK_METHOD(const void*, data, (), (const, override));
MOCK_METHOD(size_t, byte_size, (), (const, override));
};

MockTensorData::MockTensorData(size_t data_pointer_offset, size_t size) {
Expand Down
4 changes: 2 additions & 2 deletions tensorflow_federated/cc/core/impl/aggregation/protocol/config_converter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ using testing::SizeIs;

class MockFactory : public TensorAggregatorFactory {
MOCK_METHOD(StatusOr<std::unique_ptr<TensorAggregator>>, Create,
(const Intrinsic&), (const override));
(const Intrinsic&), (const, override));
MOCK_METHOD(StatusOr<std::unique_ptr<TensorAggregator>>, Deserialize,
(const Intrinsic&, std::string), (const override));
(const Intrinsic&, std::string), (const, override));
};

class ConfigConverterTest : public ::testing::Test {
Expand Down
5 changes: 3 additions & 2 deletions tensorflow_federated/cc/core/impl/aggregation/testing/mocks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class MockCheckpointParser : public CheckpointParser {
class MockCheckpointParserFactory : public CheckpointParserFactory {
public:
MOCK_METHOD(absl::StatusOr<std::unique_ptr<CheckpointParser>>, Create,
(const absl::Cord& serialized_checkpoint), (const override));
(const absl::Cord& serialized_checkpoint), (const, override));
};

class MockCheckpointBuilder : public CheckpointBuilder {
Expand All @@ -53,7 +53,8 @@ class MockCheckpointBuilder : public CheckpointBuilder {

class MockCheckpointBuilderFactory : public CheckpointBuilderFactory {
public:
MOCK_METHOD(std::unique_ptr<CheckpointBuilder>, Create, (), (const override));
MOCK_METHOD(std::unique_ptr<CheckpointBuilder>, Create, (),
(const, override));
};

class MockResourceResolver : public ResourceResolver {
Expand Down