Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got sets working with new syntax and fixed tests. #1348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duvenaud
Copy link
Contributor

@duvenaud duvenaud commented May 6, 2024

Still getting used to the new restrictive type inference.

One minor sadness is that I wasn't able to strengthen the type of Element as much as in one of the old PRs. Specifically,

struct Element(set:(Set a)) given (a|Ord) =
  val: Nat     # Could be (Fin (set_size set))

For a long time Dex couldn't handle a function call inside a type definition, then it could for a while, now it can't again.

Anyways, you told me to complain!

@dougalm
Copy link
Collaborator

dougalm commented May 6, 2024

For a long time Dex couldn't handle a function call inside a type definition, then it could for a while, now it can't again.

Ha, well I think the pendulum might swing back again on this one at least.

Btw, please do keep these coming but I'm not going to merge them until my latest rewrite is done. From your point of view it shouldn't change too much. No more effects or Data constraint but otherwise similar to the status quo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants