Articulation #209
Open
Articulation #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwlouse
requested changes
May 6, 2022
| @@ -270,11 +270,11 @@ def write_normal_batch(data, directory, file_template="normal_{:05d}.png", max_w | |||
| multi_write_image(data, path_template, write_fn=write_png, max_write_threads=max_write_threads) | |||
|
|
|||
|
|
|||
| def write_coordinates_batch(data, directory, file_template="object_coordinates_{:05d}.png", | |||
| def write_coordinates_batch(data, directory, file_template="object_coordinates_{:05d}.tiff", | |||
There was a problem hiding this comment.
please do not change from png to tiff here. That is a breaking change.
If you need coordinates as a tiff file, then add a new write_coordinates_batch_tif method and in your worker set kb.file_io.DEFAULT_WRITERS["object_coordinates"] = write_coordinates_batch_tif
| missing_textures = sorted({img.filepath for img in bpy.data.images | ||
| if tuple(img.size) == (0, 0) or len(img.filepath)>1}) | ||
| if missing_textures and not ignore_missing_textures: | ||
| raise RuntimeError(f"Missing textures: {missing_textures}") |
There was a problem hiding this comment.
Any particular reason for inlining _check_missing_textures here?
| @@ -6,6 +6,7 @@ etils[epath_no_tf] | |||
| cloudml-hypertune | |||
| google-cloud-storage | |||
| imageio | |||
| imageio-ffmpeg | |||
There was a problem hiding this comment.
I don't think this should be a mandatory kubric dependency just because the dynamic nerf worker uses it. I'd prefer adding specific instructions for additional dependencies to that worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dynamic NeRF challenge