-
Notifications
You must be signed in to change notification settings - Fork 6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add timeout to TestExoPlayer runUntil methods.
If the condition isn't fulfilled, they currently block until the test runner times out the test. Our usual approach is to timeout in the test itself so that the error message is clearly showing the blocked condition. Also clean-up some documentation. PiperOrigin-RevId: 309930198
- Loading branch information
Showing
3 changed files
with
187 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
testutils/src/test/java/com/google/android/exoplayer2/testutil/TestExoPlayerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright (C) 2020 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.android.exoplayer2.testutil; | ||
|
|
||
| import static org.junit.Assert.assertThrows; | ||
| import static org.mockito.Mockito.atMost; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import androidx.test.ext.junit.runners.AndroidJUnit4; | ||
| import com.google.android.exoplayer2.util.Clock; | ||
| import com.google.android.exoplayer2.util.Supplier; | ||
| import java.util.concurrent.TimeoutException; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.robolectric.annotation.LooperMode; | ||
|
|
||
| /** Unit test for {@link TestExoPlayer}. */ | ||
| @RunWith(AndroidJUnit4.class) | ||
| @LooperMode(LooperMode.Mode.PAUSED) | ||
| public final class TestExoPlayerTest { | ||
|
|
||
| @Test | ||
| public void runUntil_withConditionAlreadyTrue_returnsImmediately() throws Exception { | ||
| Clock mockClock = mock(Clock.class); | ||
|
|
||
| TestExoPlayer.runUntil(() -> true, /* timeoutMs= */ 0, mockClock); | ||
|
|
||
| verify(mockClock, atMost(1)).currentTimeMillis(); | ||
| } | ||
|
|
||
| @Test | ||
| public void runUntil_withConditionThatNeverBecomesTrue_timesOut() { | ||
| Clock mockClock = mock(Clock.class); | ||
| when(mockClock.currentTimeMillis()).thenReturn(0L, 41L, 42L); | ||
|
|
||
| assertThrows( | ||
| TimeoutException.class, | ||
| () -> TestExoPlayer.runUntil(() -> false, /* timeoutMs= */ 42, mockClock)); | ||
|
|
||
| verify(mockClock, times(3)).currentTimeMillis(); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| @Test | ||
| public void runUntil_whenConditionBecomesTrueAfterDelay_returnsWhenConditionBecomesTrue() | ||
| throws Exception { | ||
| Supplier<Boolean> mockCondition = mock(Supplier.class); | ||
| when(mockCondition.get()) | ||
| .thenReturn(false) | ||
| .thenReturn(false) | ||
| .thenReturn(false) | ||
| .thenReturn(false) | ||
| .thenReturn(true); | ||
|
|
||
| TestExoPlayer.runUntil(mockCondition, /* timeoutMs= */ 5674, mock(Clock.class)); | ||
|
|
||
| verify(mockCondition, times(5)).get(); | ||
| } | ||
| } |