-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an FfmpegVideoRenderer #7132
base: dev-v2
Are you sure you want to change the base?
Conversation
Thanks for re-sending this! We will figure out a way to get it merged. |
Amazing work! We are longing for this feature. |
@haohaozaici I tried to build iand test it but no luck with build
do you have any ideas, thanks! |
@volser You can add
Because I am using cmake to develop and debug, you also need to modify
It should be noted that because of my personal reasons, this pull request is developing very slowly, and currently supported scenarios are very limited! |
I've been able to get adaptive playback working with this pull request by making some separate changes to |
What is the Status here? Half year ago and no Update? |
Hi guys. When will this branch be merged? ffmpeg fallback should be a great feature |
See #2159 (comment). |
void CopyPlane(const uint8_t *source, int source_stride, uint8_t *destination, | ||
int destination_stride, int width, int height) { | ||
while (height--) { | ||
std::memcpy(destination, source, width); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if this is the wrong place to put this but,
It seems like CopyPlane needs to take the strides into account when copying data. Something like
std::memcpy(destination, source, std::min(std::min(width, source_stride), destination_stride));
prevents reading past the end of source
or writing past the end of destination
.
I'm pretty sure this is responsible for the issue reported here #9459
Please fix conflicts |
For more information, see #7079