Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuthSession final and add a delegate protocol to intercept and provide custom errors #224

Merged
merged 17 commits into from
Mar 30, 2023
Merged

Make AuthSession final and add a delegate protocol to intercept and provide custom errors #224

merged 17 commits into from
Mar 30, 2023

Commits on Mar 29, 2023

  1. Add new AuthSessionDelegate

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    fae7e9b View commit details
    Browse the repository at this point in the history

  2. Update error method to take completion

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    87f6127 View commit details
    Browse the repository at this point in the history

  3. Add some documentation

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    01ee35a View commit details
    Browse the repository at this point in the history

  4. Add tests for AuthSession selector based callbacks

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    820324a View commit details
    Browse the repository at this point in the history

  5. Update if let syntax to pass on GH

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    9933e76 View commit details
    Browse the repository at this point in the history

  6. Update copyright year to 2023 in new files

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    a9ff534 View commit details
    Browse the repository at this point in the history

  7. Rename delegate method to include token

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    8e17c47 View commit details
    Browse the repository at this point in the history

  8. Use as to cast to Swift.Error to NSError in AuthStateTests

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    76ac4bb View commit details
    Browse the repository at this point in the history

  9. Check for an AppAuth error before reassigning to an AuthSession error

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    31e0378 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary GTMAppAuthExternalError and update tests 

    This change simply forwards the error received from the AuthSession delegate to the original caller
    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    41d5e6c View commit details
    Browse the repository at this point in the history

  11. Use a barrier with the dispatch queue to ensure error can be modified… 

    … before returned
    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    693bdce View commit details
    Browse the repository at this point in the history

  12. No need for completion in updated error method

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    d9ffe2f View commit details
    Browse the repository at this point in the history

  13. Hardcode AppAuth error for GSI-iOS testing

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    1bd305b View commit details
    Browse the repository at this point in the history

  14. Make it easier to see the new error via breakpoint

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2255e39 View commit details
    Browse the repository at this point in the history

  15. Remove hardcoded AppAuth error

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5c4c2f0 View commit details
    Browse the repository at this point in the history

  16. Make keychain helper visibility public

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    66a0386 View commit details
    Browse the repository at this point in the history

  17. Some formatting in test delegate helper

    @mdmathias
    mdmathias committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4721699 View commit details
    Browse the repository at this point in the history