Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the restorePreviousSignIn when completion is nil #301

Merged
merged 6 commits into from
May 4, 2023

Conversation

henryhl22321
Copy link
Contributor

Return to void and not trigger the callback when the completion is nil.

GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
@mdmathias
Copy link
Collaborator

@henryhl22321 you will need to rebase main here after #302 is merged. #302 is needed so that the workflows pass.

GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Show resolved Hide resolved
@henryhl22321 henryhl22321 merged commit 6a329cb into main May 4, 2023
@henryhl22321 henryhl22321 deleted the hengyul/bug-fix branch May 4, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restorePreviousSignInWithCompletion() call crash if the completion is null
3 participants