-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the restorePreviousSignIn when completion is nil #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch40w31
requested changes
Apr 20, 2023
mdmathias
requested changes
Apr 20, 2023
@henryhl22321 you will need to rebase |
mdmathias
requested changes
Apr 26, 2023
mdmathias
requested changes
Apr 27, 2023
mdmathias
reviewed
Apr 29, 2023
mdmathias
approved these changes
May 3, 2023
…GIDGoogleUser on GIDSignInTest
henryhl22321
force-pushed
the
hengyul/bug-fix
branch
from
May 4, 2023 02:29
6b4871a
to
a8ce59e
Compare
ch40w31
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return to void and not trigger the callback when the completion is nil.