Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTO fix and toml cleanup #608

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

kaczmarczyck
Copy link
Collaborator

This fixes a compilation problem we have in debug mode with LTO enabled that was surfaced in workflow runs in #606 .

This also fixes a compilation problem we have in debug mode with LTO
enabled.
@kaczmarczyck kaczmarczyck requested a review from ia0 April 4, 2023 09:46
@coveralls
Copy link

Coverage Status

Coverage: 96.17% (-0.2%) from 96.403% when pulling 3a7048c on kaczmarczyck:lto-fix into 6d5ea16 on google:develop.

@kaczmarczyck
Copy link
Collaborator Author

I also fixed the other failing workflow that had an unrelated issue. Not sure how it worked before though.

@kaczmarczyck kaczmarczyck merged commit 80b82ff into google:develop Apr 4, 2023
@kaczmarczyck kaczmarczyck deleted the lto-fix branch April 4, 2023 11:40
@kaczmarczyck
Copy link
Collaborator Author

I reported the Rust problem here:

rust-lang/rust#109934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants