Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

chore(link): update link issue for Custom Elements extends #5418

Merged
merged 4 commits into from
Feb 12, 2018
Merged

chore(link): update link issue for Custom Elements extends #5418

merged 4 commits into from
Feb 12, 2018

Conversation

LasaleFamine
Copy link
Contributor

@LasaleFamine LasaleFamine commented Dec 3, 2017

Updating link for the issue related to native elements extension. (WICG/webcomponents#662)

@ebidel
Copy link
Contributor

ebidel commented Dec 3, 2017

I prefer if we keep the link as-is. It has all the historical discussion.

@LasaleFamine
Copy link
Contributor Author

Oh, I understand. Actually I was thinking could be misunderstanding come up on a closed issue as reference. A new folk can assume is a "closed argument" instead of scrolling down the whole page and find the correct issue. Maybe is worth adding also the new issue within the old one? I don't know. If not, we can close this one then.

@ebidel
Copy link
Contributor

ebidel commented Dec 3, 2017

Ok, let's add a link to the new one in addition to the old one. Sound good?

@LasaleFamine
Copy link
Contributor Author

LasaleFamine commented Dec 3, 2017

Yep, sounds good to me. Do you have some specific copy to add to explain that there are two main issues?

@petele
Copy link
Member

petele commented Dec 7, 2017

@ebidel - when you're happy with this, feel free to merge.

@ebidel
Copy link
Contributor

ebidel commented Dec 14, 2017

@LasaleFamine

"Voice your thoughts on 509 and 662". Include the links of course.

@LasaleFamine
Copy link
Contributor Author

@ebidel I think I have problems with some languages (like Chinese). Someone can help with this?

@kaycebasques kaycebasques self-requested a review February 12, 2018 22:30
@kaycebasques kaycebasques merged commit 52863c5 into google:master Feb 12, 2018
@kaycebasques
Copy link
Contributor

Thanks for the contribution @LasaleFamine

@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants