Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Placeholder] Prototype for new library #457

Merged
merged 13 commits into from
Jun 3, 2021
Merged

[Placeholder] Prototype for new library #457

merged 13 commits into from
Jun 3, 2021

Commits on Jun 2, 2021

  1. Introduce content placeholder to provide skeleton ui

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f3178c7 View commit details
    Browse the repository at this point in the history

  2. Add API file for Placeholder

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4b9293d View commit details
    Browse the repository at this point in the history

  3. Add placeholder sample

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    65097e2 View commit details
    Browse the repository at this point in the history

  4. Change PlaceholerHighlightColor to be more opaque

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    45d255a View commit details
    Browse the repository at this point in the history

  5. Remove unused Placeholder composables

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b29f47d View commit details
    Browse the repository at this point in the history

  6. Add comments to placeholder

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    59e4013 View commit details
    Browse the repository at this point in the history

  7. Remove @composable from PlaceholderAnimatedBrush

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f20a9b4 View commit details
    Browse the repository at this point in the history

  8. Add test code for PlaceholderAnimatedBrush

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e2cea99 View commit details
    Browse the repository at this point in the history

  9. Simplify the sample code by separation

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4be7685 View commit details
    Browse the repository at this point in the history

  10. Add test code for Placeholder

    @fornewid
    fornewid committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    461969e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Run metalavaGenerateSignature

    @fornewid
    fornewid committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    2c0b5a8 View commit details
    Browse the repository at this point in the history

  2. Apply code review 

    - Add the explicit return type.
- Only create one modifier on every animation frame.
- Remove equals/hashcode in Placeholder.
- Use default easing instead of LinearEasing.
- Change PlaceholderDefaults to public class.
- Move functions for PlaceholderAnimatedBrush inside the companion object.
- Add kdoc.
    @fornewid
    fornewid committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    dde0d2b View commit details
    Browse the repository at this point in the history

  3. Add kdoc for PlaceholderAnimatedBrush

    @fornewid
    fornewid committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f511320 View commit details
    Browse the repository at this point in the history