Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable Extension support #1315

Conversation

shoaibmushtaq25
Copy link
Contributor

@shoaibmushtaq25 shoaibmushtaq25 commented Apr 21, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1059

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@shoaibmushtaq25 shoaibmushtaq25 changed the title Added root level and item level variable extension support in Questio… Add variable Extension support Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1315 (64ba13c) into master (ae4c26a) will decrease coverage by 0.80%.
The diff coverage is 24.02%.

@@             Coverage Diff              @@
##             master    #1315      +/-   ##
============================================
- Coverage     84.50%   83.70%   -0.81%     
- Complexity      686      691       +5     
============================================
  Files           148      148              
  Lines         10697    10849     +152     
  Branches        832      861      +29     
============================================
+ Hits           9040     9081      +41     
- Misses         1244     1350     +106     
- Partials        413      418       +5     
Impacted Files Coverage Δ
...iews/QuestionnaireItemDropDownViewHolderFactory.kt 65.71% <0.00%> (+14.28%) ⬆️
...android/fhir/datacapture/QuestionnaireViewModel.kt 54.46% <24.18%> (-25.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac93433...64ba13c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add variable Extension support
1 participant