Repeated groups

[kevinmost]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #726

Description
Adds support for repeated groups.

Also added a sample form that uses repeated groups to record multiple COVID vaccine doses.

Several features are still missing. Given the size of this PR, it seems better to add those features in a follow-up. Most of those features would involve a header per instance of the repeated group which would allow for:

• Expanding/collapsing that instance of the group (via a caret button, using the .isHidden extension, maybe?)
• Deleting that instance of the group (via an X button)
• Labeling that instance of the group with its index
• Better visual clarity of where one group instance ends and the next starts

Alternative(s) considered
N/A

Type
Choose one: (Feature)

Screenshots (if applicable)

Example form with 2 group response instances:

Resulting JSON:

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[jingtang10]

thanks @kevinmost! this is amazing!

[Tarun-Bhardwaj]

Hi @kevinmost , could you please provide an ETA by when this can be done?

[kevinmost]

I think this is ready for re-review, @jingtang10

[f-odhiambo]

Thanks, @kevinmost Will review it. Not sure what is the issue with the failing tests CC @jingtang10

[kevinmost]

Hm, the changes from #1670 seem to be breaking my tests (reverting that commit locally shows them working again).

The issue is definitely with my PR though (I agree that the ViewModel should be the source-of-truth for answers, and QuestionnaireItemViewItem should just be a snapshot).

Testing locally, the logic still seems to work. Any suggestions on how to restructure this test so it passes, @jingtang10?

Applied all relevant changes

[jingtang10]

thanks kevin - approved.

just a commen to add some tests for the group header widget. once that's done please feel free to merge

[codecov]

Codecov Report

Merging #1559 (92f3122) into master (b505aff) will decrease coverage by 0.13%.
The diff coverage is 28.84%.

@@             Coverage Diff              @@
##             master    #1559      +/-   ##
============================================
- Coverage     41.54%   41.41%   -0.14%     
+ Complexity      377      376       -1     
============================================
  Files           150      150              
  Lines          5300     5332      +32     
  Branches        952      960       +8     
============================================
+ Hits           2202     2208       +6     
- Misses         2767     2789      +22     
- Partials        331      335       +4     

Impacted Files	Coverage Δ
...hir/datacapture/MoreQuestionnaireItemComponents.kt	35.32% <ø> (ø)
...e/views/QuestionnaireItemGroupViewHolderFactory.kt	42.85% <10.00%> (-18.26%)	⬇️
...android/fhir/datacapture/QuestionnaireViewModel.kt	48.93% <33.33%> (-1.79%)	⬇️
.../android/fhir/datacapture/QuestionnaireFragment.kt	68.96% <0.00%> (+0.78%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.