Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring apitools Python3 support. #1

Closed
dhermes opened this issue Feb 26, 2015 · 10 comments
Closed

Bring apitools Python3 support. #1

dhermes opened this issue Feb 26, 2015 · 10 comments

Comments

@dhermes
Copy link
Contributor

dhermes commented Feb 26, 2015

See @craigcitro comment.

PS Craig, https://github.com/google/protorpc does not have issues turned on.

@craigcitro
Copy link
Contributor

@dhermes thanks for the heads-up! fixed.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 26, 2015

Filed there too. /cc @tseaver

@craigcitro
Copy link
Contributor

quick question for @tseaver: when you applied the python-modernize changes to this repo, did you use any special flags?

@tseaver
Copy link
Contributor

tseaver commented Feb 28, 2015

I don't recall any flags (the fixer I wanted to disable was adding from __future__ import absolute_imports, but I couldn't figure out how).

My memory is that I generated a patch file and edited it to remove that import and correct for some other wonkiness.

@craigcitro
Copy link
Contributor

OK, we're now much closer: https://pypi.python.org/pypi/google-apitools

i've also done a massive update from internal, and merged in the gsutil fork. we're unblocked on better py3 support, IIUC.

my next step is to move gsutil over to using this code as a submodule. along those lines, i noticed that one of the changes in 901342e seemed to cause some unicode-related issues when i ran some (still-only-internal) tests; since it's late, i just stripped it out for now, but i think that one might require some digging.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 2, 2015

w00t

@craigcitro
Copy link
Contributor

OK, i made a small effort here in 3c522a4 ... but there's still hard work to be done.

in particular, i need a plan to update or drop gflags and apputils. ugh.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 2, 2015

Drop, drop, drop, drop! Woo hoo!

Make them optional in setup.py and then everyone is happy. You can go back to the origin old_run.py in oauth2client to see how we ditched gflags there. (I think you were part of those code reviews way back when.)

@dhermes
Copy link
Contributor Author

dhermes commented Mar 24, 2015

@craigcitro Can this be closed? Are gflags and apputils dropped?

@craigcitro
Copy link
Contributor

So gflags and apputils aren't gone, but i at least have a plan in place. given what you did in #5, i'm gonna close this, and open a new issue to completely drop those dependencies.

cherba pushed a commit that referenced this issue Sep 30, 2016
Update list_pager_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants