Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ecj from 3.33.0 to 3.34.0 in /common #1548

Closed
wants to merge 1 commit into from
Closed

Bump ecj from 3.33.0 to 3.34.0 in /common #1548

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 13, 2023

Bumps ecj from 3.33.0 to 3.34.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump ecj from 3.33.0 to 3.34.0 in /common
6e5ac25 
Bumps [ecj](https://github.com/eclipse-jdt/eclipse.jdt.core) from 3.33.0 to 3.34.0.
- [Commits](https://github.com/eclipse-jdt/eclipse.jdt.core/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.jdt:ecj
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 13, 2023
eamonnmcmanus
eamonnmcmanus requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a classfile version problem.

@cpovirk
Copy link
Member

cpovirk commented Jun 20, 2023

@eamonnmcmanus, do you have plans for this and #1547? I assume our main options are:

@eamonnmcmanus
Copy link
Member

@eamonnmcmanus, do you have plans for this and #1547?

I think we should just exclude the failing tests for the JDK 8 and JDK 11 configurations. I am planning to do that soon.

@cpovirk cpovirk added Component: common type=other Miscellaneous activities not covered by other type= labels P2 labels Jun 20, 2023
copybara-service bot pushed a commit that referenced this pull request Jun 20, 2023
@eamonnmcmanus
Update to the latest ECJ (Eclipse compiler).
e3a5d44 
Exclude Eclipse compilation tests on JDK platforms < 17. Previously we excluded them on platforms < 11.

Fixes #1547
Fixes #1548

RELNOTES=n/a
PiperOrigin-RevId: 541954853
@copybara-service copybara-service bot mentioned this pull request Jun 20, 2023
Merged
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 20, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/common/org.eclipse.jdt-ecj-3.34.0 branch June 20, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus requested changes

Assignees

@eamonnmcmanus eamonnmcmanus

Labels
Component: common dependencies Pull requests that update a dependency file java Pull requests that update Java code P2 Status: accepted type=other Miscellaneous activities not covered by other type= labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpovirk @eamonnmcmanus