Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate auto-factory compiler and annotations. #352

Closed
wants to merge 1 commit into from
Closed

Separate auto-factory compiler and annotations. #352

wants to merge 1 commit into from

Conversation

CoatedMoose
Copy link

No code changes, just moving files and pom configuration changes.

See issue #268.

No code changes, just moving files and pom configuration changes.

See issue #268.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@CoatedMoose
Copy link
Author

CoatedMoose commented Jun 27, 2016

I expect my pom changes might need some tweaks to conform with project conventions. I am happy to do the other modules (value and service), but I don't want to change everything and find out a different approach for separating the projects is preferred.

@cypressious
Copy link

Any updates on this since 2016?

@cpovirk
Copy link
Member

cpovirk commented Oct 2, 2019

From #268, it sounds like the split happened.

@cpovirk cpovirk closed this Oct 2, 2019
@shalk
Copy link

shalk commented Aug 1, 2024

i think the split is not happened for auto-factory compiler and annotations. this issue can be reopen

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

Thanks, my mistake.

Hmm, I can't seem to reopen this for some reason....

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

Wait, now it is letting me?

@shalk
Copy link

shalk commented Aug 1, 2024

Wait, now it is letting me?

This is pr, not issue, i think the pr is out of date.
Maybe need create a new issue "Separate auto-factory Annotations and Processor into different dependencies."

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

The UI is confusing me. First, it had "Reopen and comment" grayed out. Then, after I posted, it became available, so I posted again, and I'm pretty sure that I pressed it, but it didn't reopen. That probably does mean that the branch (or entire fork) was deleted after my wrongly closing the PR years ago. Opening another issue sounds wise. Sorry for the trouble.

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

Yeah, now the button is available again, but I assume it's still not going to work?

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

Yeah, it let me click it, but when I hovered before doing so, it told me that the repo that contained the PR had been deleted.

@CoatedMoose
Copy link
Author

It's been a hot minute since this was initially opened, and subsequently closed. I presumably deleted my fork when this issue was closed.

I've recreated my changes on the latest HEAD. See if you can reopen the PR now. If not, I'll open a new PR.

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

It doesn't seem like it's about to let me, but let me confirm that I see the same thing as before after I post this comment.

@cpovirk
Copy link
Member

cpovirk commented Aug 1, 2024

Yep, same message when I hover as before. I'll press "Reopen and comment" again for fun, but unless you see this actually reopen at that point, then a new PR is the way to go.

It seems entirely likely that we will continue to drag on doing anything about it—I wonder if we were concerned that users would need to update their build configuration when they upgrade?—but it's a highly legitimate request, and it would obviously be the right approach if we were starting from scratch.

@CoatedMoose
Copy link
Author

Opened a new PR in #1814. I'll continue discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants