Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage integration tests that fail on windows #819

Open
philipcraig opened this issue Feb 20, 2022 · 2 comments
Open

Triage integration tests that fail on windows #819

philipcraig opened this issue Feb 20, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@philipcraig
Copy link
Contributor

philipcraig commented Feb 20, 2022

#817 shows that several integration tests fail on the nightly Windows msvc or gnu rustup channels

Some of the causes of the failures are:
test_stringview uses string_view. This requires C++17, and the flag for this is not supplied to the Windows compilers
test_forward_declaration destructs a unique_ptr of an incomplete type, which is non-compliant C++ #840
test_bitset contains Clang-specific __type_visibility__ attributes
test_protected_inner_class uses designated initialisers which is only compliant for C++20
test_private_inner_class uses designated initialisers which is only compliant for C++20

Other test failures are reproducible, but so far untriaged

@philipcraig philipcraig changed the title Triage integration tests that fail on non-linux Triage integration tests that fail on windows Feb 22, 2022
@adetaylor
Copy link
Collaborator

A (presumably) flakey test: https://github.com/google/autocxx/runs/5337017794?check_suite_focus=true - test_uniqueptr_moveit. This might be a real bug which just happens to manifest on Windows only due to ABI issues. I'd like to figure out how to run the test suite under ASAN on Linux to see if any problems show up.

@philipcraig
Copy link
Contributor Author

philipcraig commented Feb 26, 2022

A (presumably) flakey test: https://github.com/google/autocxx/runs/5337017794?check_suite_focus=true - test_uniqueptr_moveit. This might be a real bug which just happens to manifest on Windows only due to ABI issues. I'd like to figure out how to run the test suite under ASAN on Linux to see if any problems show up.

It's unusual that it's flaky. None of the already ignored Windows tests were flaky. The flakiness in tests that we saw while I was adding channels was in the beta and nightly channels on all of the architectures, due to incremental compilation bugs. There of course could be more of those.

adetaylor added a commit that referenced this issue Feb 27, 2022
These are failing on Windows only for unknown reasons and will
be investigated in #819.
adetaylor added a commit that referenced this issue Feb 27, 2022
These are failing on Windows only for unknown reasons and will
be investigated in #819.
@adetaylor adetaylor added the good first issue Good for newcomers label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants