-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSVC ARM64 support #1052
Add MSVC ARM64 support #1052
Conversation
Ping |
I would personally say that upstream CMake should land the fix first. |
That's a 6-year old issue and I haven't seen merge requests addressing it. I doubt fixing it upstream is on the horizon. That said, cmake fix would be the best. |
Did anyone actually submit the patch upstream? |
@LebedevRI I'm trying to get Google benchmark packaged for arm64 with MSVC using vcpkg, but they, understandably, don't want new features, just the packaging fixes. So far you only voiced concerns regarding packaging, but nothing regarding the timing code itself. Would you accept a PR with just the C++ bits extracted from this one and leave this one for packaging/cmake only? Do you have any expectation of what should be the next steps? I can look for any patches to address this problem in cmake and assess when it might get released. I don't intend to fix the guy theyü⁷ problem |
See my previous comment - did anyone actually tried to upstream that patch into CMake proper? |
a31f7c3
to
0ee6376
Compare
@LebedevRI as your comments are with regards to CMake, I've split this patch to add reading counter support here and cmake stuff now lives at #1090 |
I trust that you have manually ensured that the benchmarking results are actually meaningful there. |
Ran all the tests on my Raspberry Pi and it works fine. Results attached.
user_counters_thousands_test.txt
user_counters_test.txt
user_counters_tabular_test.txt
templated_fixture_test.txt
string_util_gtest.txt
statistics_gtest.txt
skip_with_error_test.txt
report_aggregates_only_test.txt
register_benchmark_test.txt
options_test.txt
multiple_ranges_test.txt
memory_manager_test.txt
map_test.txt
link_main_test.txt
internal_threading_test.txt
filter_test.txt