Add nb::is_flag()
annotation to Counter::Flags
#1870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves us the definition of
__or__
, because we can just use the one fromenum.IntFlag
.cc @hawkinsp for a review, since you mentioned this should be possible after flag enum support is added to nanobind, which it is now, starting in v2.2.0.
I did have to use both
nb::is_arithmetic()
andnb::is_flag()
due to combination issues, but it seems the C++ side is aware of this:benchmark/include/benchmark/benchmark.h
Lines 720 to 726 in 4e3f2d8