Skip to content

Commit

Permalink
CMake: Raise minimum version to 3.20, add GitHub Actions for BinDiff
Browse files Browse the repository at this point in the history
- Better support for MSVC runtime on Windows

PiperOrigin-RevId: 601758012
Change-Id: I4015c23ba6790ebdbe2405102f8d9885d56f7aca
  • Loading branch information
cblichmann authored and copybara-github committed Jan 26, 2024
1 parent 76dd947 commit e87083b
Show file tree
Hide file tree
Showing 2 changed files with 88 additions and 5 deletions.
78 changes: 78 additions & 0 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
name: cmake-build

on: [push, pull_request]

env:
BUILD_TYPE: Release

jobs:
build:
strategy:
fail-fast: false
matrix:
include:
- os: ubuntu-22.04
- os: macos-12
- os: windows-2022
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v4
with:
path: bindiff
- uses: actions/checkout@v4
with:
repository: google/binexport
path: binexport

- name: Install ninja-build tool
uses: turtlesec-no/[email protected]

- name: Create Build Environment
env:
IDASDK_SECRET: ${{ secrets.IDASDK_SECRET }}
working-directory: ${{ github.workspace }}
shell: bash
run: |
mkdir -p "${{ runner.workspace }}/build" \
ida/idasdk
mv binexport/ida/idasdk/idasdk*.gpg \
ida/idasdk/
binexport/.github/scripts/decrypt_secret.sh
unzip -q "${{ runner.workspace }}/build/idasdk_teams80.zip" \
-d "${{ runner.workspace }}/build/"
- name: Enable Developer Command Prompt (Windows)
if: matrix.os == 'windows-2022'
uses: ilammy/[email protected]

- name: Enable mold linker (Linux)
if: matrix.os == 'ubuntu-22.04'
uses: rui314/setup-mold@v1

- name: Configure CMake
working-directory: ${{ runner.workspace }}/build
shell: bash
run: |
cmake "${{ github.workspace }}/bindiff" -G Ninja \
"-DCMAKE_BUILD_TYPE=${BUILD_TYPE}" \
"-DIdaSdk_ROOT_DIR=${{ runner.workspace }}/build/idasdk_teams80"
- name: Build
working-directory: ${{ runner.workspace }}/build
shell: bash
run: cmake --build . --config "${BUILD_TYPE}"

- name: Test
working-directory: ${{ runner.workspace }}/build
shell: bash
run: ctest --build-config "${BUILD_TYPE}" --output-on-failure -R '^[A-Z]'

- name: Upload Build Artifacts
uses: actions/[email protected]
with:
name: BinDiff-${{ runner.os }}
path: |
${{ runner.workspace }}/build/bindiff
${{ runner.workspace }}/build/ida/bindiff*
${{ runner.workspace }}/build/tools/bindiff*
15 changes: 10 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,18 @@

# CMake build file for BinDiff. This file relies on the open source version of
# BinExport a lot.
cmake_minimum_required(VERSION 3.14..3.24)
cmake_minimum_required(VERSION 3.20..3.28)

cmake_policy(VERSION 3.14)
cmake_policy(VERSION 3.20)

if(POLICY CMP0135)
cmake_policy(SET CMP0135 NEW) # Set download timestamp to current time
endif()
foreach(_bindiff_policy IN ITEMS
CMP0135 # Set download timestamp to current time
CMP0144 # Use upper-case <PACKAGENAME>_ROOT variables
)
if(POLICY ${_bindiff_policy})
cmake_policy(SET ${_bindiff_policy} NEW)
endif()
endforeach()

project(bindiff VERSION 8)

Expand Down

0 comments on commit e87083b

Please sign in to comment.